Repository navigation
perf: Replace O(n) slice scans with O(1) map lookups in NewKey() and NewSection() - #378
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Fixes #377
Changes
Replace
inSlice()linear scan with direct map lookup in two hot paths:section.go —
NewKey()file.go —
NewSection()Both slices (
keyList,sectionList) are always kept in sync with theircorresponding maps (
keys,sections), so the semantics are unchanged.Benchmark
Added
Benchmark_NewKey_With_N_KeysandBenchmark_NewSection_With_N_Sectionsto verify the improvement.
Before (O(n) — linear growth):
After (O(1) — constant time):
At 1000 keys/sections: ~43x faster for NewKey, ~57x faster for NewSection.
Checklist