Repository navigation
Recognize Go 1.27 JSON v2 marshaling in SA9005 - #1753
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognize the exact MarshalJSONTo(*jsontext.Encoder) error and UnmarshalJSONFrom(*jsontext.Decoder) error contracts as custom marshaling methods for encoding/json in the Go 1.27 JSON v2 configuration. This avoids SA9005 false positives for structs with only unexported fields while retaining diagnostics for same-named methods with incompatible signatures. Legacy marshaling checks are unchanged.
Fixes #1744.
Validation: GOTOOLCHAIN=go1.27.0 GOPROXY=off GOEXPERIMENT=jsonv2 go test ./staticcheck/sa9005 passed. The repository fixture harness still skips its Go 1.27 group due to its version ceiling; this is not claimed as fixture acceptance. The new signature unit test passes. Separately, direct production staticcheck CLI execution with Go 1.27 reports both JSON calls on the incompatible-signature fixture and emits no SA9005 on the valid-v2 MarshalJSONTo fixture. Prior runtime verification confirms the valid method is dispatched by encoding/json and encoding/json/v2 in this configuration. No full-suite or CI acceptance claimed.