Repository navigation
Avoid unsafe De Morgan fixes for type parameters - #1782
Open
dajiaohuang wants to merge 3 commits into
Open
dajiaohuang wants to merge 3 commits into
dajiaohuang wants to merge 3 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The De Morgan quick fix suppresses rewrites when a comparison contains floating point values, because NaN makes negated comparisons differ from their inverse. A type parameter has an interface underlying type even when its constraint permits floating point values, so the current check misses generic comparisons. Suppress the suggestion when an expression has a type parameter and add a Go 1.18 regression fixture.
Review update: the unrelated generic-instantiation change and its fixture were removed through a normal follow-up commit; #1764 tracks that fix separately. Current-head validation: go test ./quickfix/qf1001 (three tests) passed; git diff --check passed. Prior validation text above is historical unless repeated here.