Repository navigation
SA1026, SA9005: check MarshalIndent functions - #1713
Merged
Merged
Conversation
Owner
|
Can you drop the commit bumping actions/checkout? The CI failure was transient. |
Because the logic on what can be marshaled doesn't differ, we can re-use the existing checkJSON and checkXML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While extracting a small test case from my real code for #1712, I suddenly could not longer reproduce it. Turns out that was because I used json.MarshalIndent() for my test case, and this function wasn't checked.
Fixes #1264