Repository navigation
Check the reachable time.Tick receive branch - #1809
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminates recognizes the reachable receive branch of time.Tick: the channel does not close, so an explicit return on ok=true can terminate, whereas a return only on ok=false is unreachable. Handle the optional negation of the receive status before selecting the reachable branch.
The new regression cases use a positive tick interval, since time.Tick(0) returns a nil channel and cannot exercise a live receive branch. Legacy fixture cases are preserved.
Validation after fixture correction: go test ./staticcheck/sa1015 ./go/ir/irutil passed (nine tests); gofmt and git diff --check passed.