Repository navigation
Anchor module version suffix detection - #1830
Closed
dajiaohuang wants to merge 1 commit into
Closed
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module suffix check matched any occurrence of v followed by digits in the final path segment. A valid module path ending in v2beta could therefore be misclassified as a /v2 module and assigned proxy version v2.0.0, inconsistent with its path.
Anchor the regular expression to the entire final segment, accepting v followed only by digits. Current-patch semantic review and git diff --check completed. No focused regression or package test was run for this submission; prior coordinator instructions limited its initial validation to static review.